fix: TaskTracer validation error (Fixes #55)#56
Merged
BinWang28 merged 1 commit intoMiroMindAI:miroflow-v0.3from Sep 29, 2025
Merged
fix: TaskTracer validation error (Fixes #55)#56BinWang28 merged 1 commit intoMiroMindAI:miroflow-v0.3from
BinWang28 merged 1 commit intoMiroMindAI:miroflow-v0.3from
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a validation error in the task tracing functionality when numeric task IDs are passed via command line arguments. The issue occurred because Fire parsed --task_id=15 as an integer, but the single_task function expects a string parameter.
- Cast numeric task_id to string when calling single_task function
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
BinWang28
approved these changes
Sep 29, 2025
Zhudongsheng75
pushed a commit
to open-compass/MiroFlow
that referenced
this pull request
Dec 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe this PR
This PR fixes a validation error that occurred when passing a numeric task_id to the trace command. Previously, Fire parsed --task_id=15 as an integer, which was then propagated to TaskTracer as both task_id and task_name, causing Pydantic to raise a string type validation error. The fix is to cast task_id to a string when calling single_task explicitly.
Checklist for PR
Must Do
feat(agent): add pdf tool via mcp,perf: make llm client asyncandfix(utils): load custom config via importlibetc. CI jobcheck-pr-titleenforces Angular commit message format to PR title.make precommitlocally. CI joblintenforce ruff default format/lint rules on all new codes.make pytest. Check test summary (located atreport.html) and coverage report (located athtmlcov/index.html) on new codes.Nice To Have
/testsforfeatandtestPR./docsfordocsandciPR.